Skip to content

Don't load component when fetching translations#23196

Merged
balloob merged 1 commit into
devfrom
translation-load-component
Apr 18, 2019
Merged

Don't load component when fetching translations#23196
balloob merged 1 commit into
devfrom
translation-load-component

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 18, 2019

Description:

Loading translations would load all the integrations component files, resulting in an error for Hue, since Hue imports its requirements at the top.

Fix issue reported by @VDRainer on Discord.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.92.0 milestone Apr 18, 2019
@balloob balloob requested a review from a team as a code owner April 18, 2019 16:15
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Apr 18, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2019

Codecov Report

Merging #23196 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23196      +/-   ##
==========================================
- Coverage   94.17%   94.17%   -0.01%     
==========================================
  Files         457      457              
  Lines       37096    37095       -1     
==========================================
- Hits        34937    34936       -1     
  Misses       2159     2159
Impacted Files Coverage Δ
homeassistant/helpers/translation.py 98.68% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1338a...4105472. Read the comment docs.

@balloob balloob merged commit fda483f into dev Apr 18, 2019
@delete-merged-branch delete-merged-branch Bot deleted the translation-load-component branch April 18, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants