Misc. ZHA changes#23190
Merged
Merged
Conversation
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( |
Adminiuga
previously approved these changes
Apr 18, 2019
Contributor
Adminiuga
left a comment
Adminiuga
left a comment
There was a problem hiding this comment.
Looks good. Can be merged on build pass.
Contributor
Author
|
ready for final review |
Adminiuga
approved these changes
Apr 18, 2019
Contributor
Adminiuga
left a comment
Adminiuga
left a comment
There was a problem hiding this comment.
Good to be merged on build pass.
Contributor
|
Those warning on device re-joins were obnoxious. Good to finally get rid of them. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements on with timed off and it also cleans up the configuration phase for ZCL clusters to ensure we don't pass the same cluster through configuration multiple times.
Checklist:
tox. Your PR cannot be merged unless tests pass