Potential None#23187
Merged
Merged
Conversation
homeassistant
added
cla-signed
core
integration: automation
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
pvizeli
approved these changes
Apr 18, 2019
awarecan
reviewed
Apr 18, 2019
| 'to_state': to_s, | ||
| }, | ||
| }, context=to_s.context)) | ||
| }, context=(to_s.context if to_s else None))) |
Contributor
There was a problem hiding this comment.
We should not set None to context. I have a open PR to fix similar issue, #21801
Member
|
Filed an issue with the correct solution #23194 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Minor bugfix. Line of code fixed has potential for target state to be None when state is being deleted and an exception would happen.
In this case it's not unreasonable to not pass the context because that will be a system event anyhow. This will be fixed anyhow as part of #22587 anyhow.
Checklist:
tox. Your PR cannot be merged unless tests pass