Skip to content

Further improve IndieAuth redirect_uri lookup failure logs#23183

Merged
balloob merged 1 commit intodevfrom
more-indieauth-logging
Apr 18, 2019
Merged

Further improve IndieAuth redirect_uri lookup failure logs#23183
balloob merged 1 commit intodevfrom
more-indieauth-logging

Conversation

@robbiet480
Copy link
Copy Markdown
Contributor

@robbiet480 robbiet480 commented Apr 18, 2019

Continuing work from #21780, this PR adds some more specific logging for common errors that I've seen reported from iOS users. The excepts are ordered in the same way as the aiohttp Hierarchy of exceptions.

@robbiet480 robbiet480 requested a review from a team as a code owner April 18, 2019 05:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (auth) you are listed as a codeowner for? Thanks!

@robbiet480 robbiet480 force-pushed the more-indieauth-logging branch from 1116936 to 59f428c Compare April 18, 2019 06:00
balloob
balloob reviewed Apr 18, 2019
View reviewed changes
Comment thread homeassistant/components/auth/indieauth.py
break

except (asyncio.TimeoutError, ClientError) as ex:
_LOGGER.error("Error while looking up redirect_uri %s: %s", url, ex)
Copy link
Copy Markdown
Member

@balloob balloob Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the error message ex not descriptive enough?

Copy link
Copy Markdown
Contributor Author

@robbiet480 robbiet480 Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no string version of ClientError sadly, so nothing is output for that bit.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2019

Codecov Report

Merging #23183 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23183      +/-   ##
==========================================
- Coverage   94.21%   94.17%   -0.04%     
==========================================
  Files         457      457              
  Lines       37085    37096      +11     
==========================================
- Hits        34938    34937       -1     
- Misses       2147     2159      +12
Impacted Files Coverage Δ
homeassistant/components/auth/indieauth.py 77.08% <0%> (-11.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2a130...59f428c. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2019 •
edited
Loading

Codecov Report

Merging #23183 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23183      +/-   ##
==========================================
- Coverage   94.21%   94.17%   -0.04%     
==========================================
  Files         457      457              
  Lines       37085    37096      +11     
==========================================
- Hits        34938    34937       -1     
- Misses       2147     2159      +12
Impacted Files Coverage Δ
homeassistant/components/auth/indieauth.py 77.08% <0%> (-11.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2a130...59f428c. Read the comment docs.

@balloob balloob merged commit 5e1338a into dev Apr 18, 2019
@delete-merged-branch delete-merged-branch Bot deleted the more-indieauth-logging branch April 18, 2019 16:03
@robbiet480 robbiet480 added this to the 0.92.2 milestone Apr 28, 2019
balloob pushed a commit that referenced this pull request May 2, 2019
@robbiet480 @balloob
Further improve IndieAuth redirect_uri lookup failure logs (#23183)
e054d68
@balloob balloob mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balloob balloob balloob left review comments

Assignees

No one assigned

Labels

cherry-picked cla-signed core integration: auth small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.92.2

Development

Successfully merging this pull request may close these issues.

4 participants

@robbiet480 @balloob @OverloadUT @homeassistant