Merged
Conversation
awarecan
reviewed
Apr 17, 2019
| """Generate a mock manifest to represent this module.""" | ||
| return { | ||
| **loader.manifest_from_legacy_module(self), | ||
| **loader.manifest_from_legacy_module(self.DOMAIN, self), |
Member
Author
There was a problem hiding this comment.
it's generating a manifest from a Python module. The new approach for integrations is that manifests are their own file.
Codecov Report
@@ Coverage Diff @@
## dev #23177 +/- ##
==========================================
- Coverage 94.19% 94.19% -0.01%
==========================================
Files 453 453
Lines 36915 36915
==========================================
- Hits 34773 34772 -1
- Misses 2142 2143 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When a platform is loaded, we will now always load the component. We incorrectly assumed that when we load the component, there was a
DOMAINconstant.Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: