Fix niko home control dependency installation by NoUseFreak · Pull Request #23176 · home-assistant/core

NoUseFreak · 2019-04-17T21:16:24Z

Breaking Change:

None

Description:

By upgrading the package, it now installs it's dependencies.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for `configuration.yaml` (if applicable):

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly (example).
New dependencies have been added to requirements in the manifest (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

MartinHjelmare

Looks good! Can be merged when comment is addressed and build passes.

MartinHjelmare · 2019-04-18T03:43:05Z

+        for state in self.data:
+            if state['id'] == aid:
+                return state['value1'] != 0
+        _LOGGER.error("Failed to retrieve state off unknown light.")


We don't end logging messages with period.

codecov · 2019-04-18T07:00:29Z

Codecov Report

Merging #23176 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             dev   #23176      +/-   ##
=========================================
- Coverage   94.2%   94.19%   -0.01%     
=========================================
  Files        453      453              
  Lines      36915    36915              
=========================================
- Hits       34776    34773       -3     
- Misses      2139     2142       +3

Impacted Files	Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py	`94.68% <0%> (-3.2%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6349a6...2e52088. Read the comment docs.

codecov · 2019-04-18T07:00:29Z

Codecov Report

Merging #23176 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             dev   #23176      +/-   ##
=========================================
- Coverage   94.2%   94.19%   -0.01%     
=========================================
  Files        453      453              
  Lines      36915    36915              
=========================================
- Hits       34776    34773       -3     
- Misses      2139     2142       +3

Impacted Files	Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py	`94.68% <0%> (-3.2%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6349a6...2e52088. Read the comment docs.

codecov · 2019-04-18T07:00:30Z

Codecov Report

Merging #23176 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             dev   #23176      +/-   ##
=========================================
- Coverage   94.2%   94.19%   -0.01%     
=========================================
  Files        453      453              
  Lines      36915    36915              
=========================================
- Hits       34776    34773       -3     
- Misses      2139     2142       +3

Impacted Files	Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py	`94.68% <0%> (-3.2%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6349a6...2e52088. Read the comment docs.

codecov · 2019-04-18T07:00:30Z

Codecov Report

Merging #23176 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             dev   #23176      +/-   ##
=========================================
- Coverage   94.2%   94.19%   -0.01%     
=========================================
  Files        453      453              
  Lines      36915    36915              
=========================================
- Hits       34776    34773       -3     
- Misses      2139     2142       +3

Impacted Files	Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py	`94.68% <0%> (-3.2%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6349a6...2e52088. Read the comment docs.

* Upgrade niko-home-control library * Fix additional feedback * Lint

homeassistant added integration: niko_home_control cla-signed labels Apr 17, 2019

OverloadUT added the in progress label Apr 17, 2019

NoUseFreak force-pushed the fix-niko-home-control branch from d870816 to 4443d92 Compare April 17, 2019 21:17

Upgrade niko-home-control library

aff73ef

NoUseFreak force-pushed the fix-niko-home-control branch from 4443d92 to aff73ef Compare April 17, 2019 21:22

Fix additional feedback

bb9d589

NoUseFreak mentioned this pull request Apr 17, 2019

Fix niko_home_control integration #23093

Merged

10 tasks

awarecan added this to the 0.92.0 milestone Apr 17, 2019

MartinHjelmare approved these changes Apr 18, 2019

View reviewed changes

Lint

2e52088

MartinHjelmare merged commit 6e4083d into home-assistant:dev Apr 18, 2019

MartinHjelmare removed the in progress label Apr 18, 2019

balloob added the cherry-picked label Apr 20, 2019

balloob pushed a commit that referenced this pull request Apr 20, 2019

Fix niko home control dependency installation (#23176)

decaabe

* Upgrade niko-home-control library * Fix additional feedback * Lint

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix niko home control dependency installation#23176

Fix niko home control dependency installation#23176
MartinHjelmare merged 3 commits intohome-assistant:devfrom
NoUseFreak:fix-niko-home-control

NoUseFreak commented Apr 17, 2019 •

edited

Loading

Uh oh!

MartinHjelmare left a comment

Uh oh!

MartinHjelmare Apr 18, 2019

Uh oh!

codecov Bot commented Apr 18, 2019

Uh oh!

codecov Bot commented Apr 18, 2019

Uh oh!

codecov Bot commented Apr 18, 2019

Uh oh!

codecov Bot commented Apr 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

NoUseFreak commented Apr 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Change:

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 18, 2019

Codecov Report

Uh oh!

codecov Bot commented Apr 18, 2019

Codecov Report

Uh oh!

codecov Bot commented Apr 18, 2019

Codecov Report

Uh oh!

codecov Bot commented Apr 18, 2019

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NoUseFreak commented Apr 17, 2019 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):