Google assistant skip missing type#23174
Merged
balloob merged 6 commits intohome-assistant:devfrom Apr 18, 2019
Merged
Conversation
homeassistant
added
cla-signed
core
has-tests
integration: google_assistant
small-pr
balloob
approved these changes
Apr 17, 2019
Member
|
No wait, this is wrong. If there are traits that are supported, we should have a device type for it. |
Member
|
Alright, made a few tweaks:
|
balloob
approved these changes
Apr 18, 2019
Codecov Report
@@ Coverage Diff @@
## dev #23174 +/- ##
===========================================
- Coverage 94.19% 61.96% -32.24%
===========================================
Files 453 454 +1
Lines 36915 36920 +5
===========================================
- Hits 34772 22876 -11896
- Misses 2143 14044 +11901
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #23174 +/- ##
==========================================
+ Coverage 94.19% 94.19% +<.01%
==========================================
Files 453 454 +1
Lines 36915 36920 +5
==========================================
+ Hits 34772 34777 +5
Misses 2143 2143
Continue to review full report at Codecov.
|
balloob
pushed a commit
that referenced
this pull request
Apr 18, 2019
* Skip entity if no device type found * Add test for potentially skipped binary sensors * Reorg code, add tests to ensure all exposed things have types * Lint * Fix tests * Lint
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Skip entity if no device type found * Add test for potentially skipped binary sensors * Reorg code, add tests to ensure all exposed things have types * Lint * Fix tests * Lint
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Skip entity if no device type found * Add test for potentially skipped binary sensors * Reorg code, add tests to ensure all exposed things have types * Lint * Fix tests * Lint
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Skip entity if no device type found * Add test for potentially skipped binary sensors * Reorg code, add tests to ensure all exposed things have types * Lint * Fix tests * Lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Don't sync entities that don't map to a known google type
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
[ ] Documentation added/updated in home-assistant.ioIf the code communicates with devices, web services, or third-party tools:
[ ] The manifest file has all fields filled out correctly (example).[ ] New dependencies have been added torequirementsin the manifest (example).[ ] New dependencies are only imported inside functions that use them (example).[ ] New or updated dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.[ ] New files were added to.coveragerc.If the code does not interact with devices: