Skip to content

Fix telegram bot verify_ssl issue#23147

Closed
cgtobi wants to merge 1 commit into
home-assistant:devfrom
cgtobi:telegram_bot_test
Closed

Fix telegram bot verify_ssl issue#23147
cgtobi wants to merge 1 commit into
home-assistant:devfrom
cgtobi:telegram_bot_test

Conversation

@cgtobi
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi commented Apr 16, 2019

Description:

Fix 'verify_ssl` flag issue after bad advice in PR review.

Related issue (if applicable): fixes #23140 and #22067

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Anonym-tsk
Copy link
Copy Markdown
Contributor

Duplicate #23146

@cgtobi cgtobi closed this Apr 16, 2019
@cgtobi cgtobi deleted the telegram_bot_test branch April 16, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

telegram_bot: verify_ssl configuration doesn't work

4 participants