Skip to content

Add missing async for tplink's async_setup_platform methods#23066

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
rytilahti:fix_tplink_async
Apr 13, 2019
Merged

Add missing async for tplink's async_setup_platform methods#23066
MartinHjelmare merged 2 commits intohome-assistant:devfrom
rytilahti:fix_tplink_async

Conversation

@rytilahti
Copy link
Copy Markdown
Member

thanks to @MartinHjelmare for spotting this, related to #21916

Breaking Change:

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned rytilahti Apr 13, 2019
@ghost ghost added the in progress label Apr 13, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can be merged when build passes.

@fabaff fabaff changed the title add missing async for tplink's async_setup_platform methods Add missing async for tplink's async_setup_platform methods Apr 13, 2019
@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 13, 2019

ok to merge when line length fixed.

@codecov

This comment has been minimized.

3 similar comments
@codecov

This comment has been minimized.

@codecov

This comment has been minimized.

@codecov

This comment has been minimized.

@MartinHjelmare MartinHjelmare merged commit 39264af into home-assistant:dev Apr 13, 2019
@ghost ghost removed the in progress label Apr 13, 2019
@rytilahti rytilahti deleted the fix_tplink_async branch April 14, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants