Skip to content

HEOS confirm discovered devices before adding#23063

Merged
andrewsayre merged 3 commits intodevfrom
heos_ask_discovery
Apr 13, 2019
Merged

HEOS confirm discovered devices before adding#23063
andrewsayre merged 3 commits intodevfrom
heos_ask_discovery

Conversation

@andrewsayre
Copy link
Copy Markdown
Member

Description:

Modify the HEOS discovery config flow to show a host selection form as a step to confirm setup. Previously, the integration would setup a config entry without asking the user using the first host discovered. PR also fixes 2 issues in the strings.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2019

Codecov Report

Merging #23063 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23063      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +<.01%     
==========================================
  Files         451      451              
  Lines       36759    36765       +6     
==========================================
+ Hits        34531    34538       +7     
+ Misses       2228     2227       -1
Impacted Files Coverage Δ
homeassistant/components/heos/config_flow.py 100% <100%> (ø) ⬆️
homeassistant/components/heos/const.py 100% <100%> (ø) ⬆️
homeassistant/components/aws/const.py 100% <0%> (ø) ⬆️
homeassistant/helpers/translation.py 98.73% <0%> (+0.03%) ⬆️
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a473a...ef71735. Read the comment docs.

Comment thread homeassistant/components/heos/.translations/ca.json
Comment thread homeassistant/components/heos/config_flow.py Outdated
Comment thread homeassistant/components/heos/config_flow.py Outdated
Comment thread homeassistant/components/heos/config_flow.py Outdated
Comment thread homeassistant/components/heos/config_flow.py Outdated
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge when comments addressed

@andrewsayre
Copy link
Copy Markdown
Member Author

Comments addressed and build passing. Merging!

@andrewsayre andrewsayre merged commit 8c89e26 into dev Apr 13, 2019
@ghost ghost removed the in progress label Apr 13, 2019
@delete-merged-branch delete-merged-branch Bot deleted the heos_ask_discovery branch April 13, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants