HEOS confirm discovered devices before adding#23063
Merged
andrewsayre merged 3 commits intodevfrom Apr 13, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #23063 +/- ##
==========================================
+ Coverage 93.93% 93.94% +<.01%
==========================================
Files 451 451
Lines 36759 36765 +6
==========================================
+ Hits 34531 34538 +7
+ Misses 2228 2227 -1
Continue to review full report at Codecov.
|
balloob
reviewed
Apr 13, 2019
balloob
reviewed
Apr 13, 2019
balloob
reviewed
Apr 13, 2019
balloob
reviewed
Apr 13, 2019
balloob
approved these changes
Apr 13, 2019
Member
balloob
left a comment
There was a problem hiding this comment.
Ok to merge when comments addressed
MartinHjelmare
approved these changes
Apr 13, 2019
Member
Author
|
Comments addressed and build passing. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Modify the HEOS discovery config flow to show a host selection form as a step to confirm setup. Previously, the integration would setup a config entry without asking the user using the first host discovered. PR also fixes 2 issues in the strings.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: