Skip to content

Update RainMachine sensors in parallel#23057

Merged
bachya merged 1 commit intohome-assistant:devfrom
bachya:rainmachine-updates
Apr 12, 2019
Merged

Update RainMachine sensors in parallel#23057
bachya merged 1 commit intohome-assistant:devfrom
bachya:rainmachine-updates

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Apr 12, 2019

Description:

This PR forces the rainmachine integration to update data for all sensors in parallel.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

rainmachine:
  controllers:
    - ip_address: !secret rainmachine_ip
      password: !secret rainmachine_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies are only imported inside functions that use them (example).

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov

This comment has been minimized.

3 similar comments
@codecov

This comment has been minimized.

@codecov

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2019

Codecov Report

Merging #23057 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23057      +/-   ##
==========================================
+ Coverage   93.94%   93.94%   +<.01%     
==========================================
  Files         451      451              
  Lines       36758    36760       +2     
==========================================
+ Hits        34531    34533       +2     
  Misses       2227     2227
Impacted Files Coverage Δ
homeassistant/components/rainmachine/const.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51508d6...e4faf99. Read the comment docs.

@bachya bachya merged commit 05f267d into home-assistant:dev Apr 12, 2019
@ghost ghost removed the in progress label Apr 12, 2019
@bachya bachya deleted the rainmachine-updates branch April 12, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants