Support cover.stop service for HomeKit Window Covers#23046
Merged
balloob merged 1 commit intohome-assistant:devfrom Apr 17, 2019
Merged
Support cover.stop service for HomeKit Window Covers#23046balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
has-tests
integration: homekit_controller
small-pr
ghost
added
the
Jc2k
changed the title
balloob
approved these changes
Apr 17, 2019
Member
|
@Jc2k could you add yourself to the code owners of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As part of #21775 I added support for
cover.stopfor HomeKit powered window covers by supporting writes to theposition.holdcharacteristic. Unfortunately this isn't actually supported by the device mentioned in the ticket, but is valid for other HomeKit window covers.This also removes support for reading
position.hold. It looks like that code was broken already, but also it turns out (according to HomeKit spec) this is a write-only characteristic and shouldn't be read.Checklist:
tox. Your PR cannot be merged unless tests pass