Conversation
38463c0 to
51eee6e
Compare
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Is all the blank lines intended?
There was a problem hiding this comment.
oh lol, no, should not have committed. That was a test.
There was a problem hiding this comment.
I have a new thing where we don't generate if validation failed.
There was a problem hiding this comment.
I am thinking about allowing the current get_component references, but not allowing new ones, while we figure out how to deal with calls to hass.components. Thinking about introducing a new "soft" dependency, integrations you want available, but don't need set up. Does that make sense?
There was a problem hiding this comment.
Yes! I definitely think we need that soft dependency. Eg some components, like owntracks, mysensors, need mqtt only in some cases.
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## dev #23037 +/- ##
==========================================
+ Coverage 93.94% 93.94% +<.01%
==========================================
Files 450 451 +1
Lines 36754 36813 +59
==========================================
+ Hits 34527 34585 +58
- Misses 2227 2228 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #23037 +/- ##
==========================================
+ Coverage 93.94% 93.94% +<.01%
==========================================
Files 450 451 +1
Lines 36754 36813 +59
==========================================
+ Hits 34527 34585 +58
- Misses 2227 2228 +1
Continue to review full report at Codecov.
|
Description:
Update our manifest validator. Make it easier to support different checks.
Adds a new check to make sure that all other integrations an integration uses, are defined in dependencies. This is obviously not realistic right now and so Circle will fail. The idea is that we come up with an approach to make this actually work. I have now made it warnings, not fatal errors. Trying to find solution in home-assistant/architecture#196
New change: we will not generate things based off manifests unless all other things are valid.
Work related to #23004
Current output: