Skip to content

Bandage telegram bot#23022

Merged
balloob merged 4 commits into
home-assistant:devfrom
dgomes:bandage_telegram_bot
Apr 12, 2019
Merged

Bandage telegram bot#23022
balloob merged 4 commits into
home-assistant:devfrom
dgomes:bandage_telegram_bot

Conversation

@dgomes
Copy link
Copy Markdown
Contributor

@dgomes dgomes commented Apr 11, 2019

Description:

This is just a quick fix... many things wrong with the integration, will require a full rewrite even because the upstream library has suffered an important refactor in version 12

https://github.com/python-telegram-bot/python-telegram-bot/wiki/Transition-guide-to-Version-12.0

Related issue (if applicable): fixes #23011

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

telegram_bot:
  - platform: polling
    api_key: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
    allowed_chat_ids:
      - 132312312
  - platform: webhooks
    api_key: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
    parse_mode: html
    allowed_chat_ids:
      - 123123123

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/telegram_bot/broadcast.py
Comment thread homeassistant/components/telegram_bot/polling.py
Comment thread homeassistant/components/telegram_bot/webhooks.py Outdated
@balloob balloob removed this from the 0.92.0 milestone Apr 11, 2019
@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 11, 2019

Removing the milestone because it will confuse our milestone cherry picker script once we cut the beta. It's not needed now as we haven't cut the beta.

Comment thread homeassistant/components/telegram_bot/__init__.py Outdated
@balloob balloob merged commit 51508d6 into home-assistant:dev Apr 12, 2019
@ghost ghost removed the in progress label Apr 12, 2019
@awarecan awarecan mentioned this pull request Apr 16, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

telegram_bot identifies as a platform integration

3 participants