Skip to content

Allow aws credential skip validation#22991

Merged
awarecan merged 2 commits into
home-assistant:devfrom
awarecan:aws-skip-validation
Apr 13, 2019
Merged

Allow aws credential skip validation#22991
awarecan merged 2 commits into
home-assistant:devfrom
awarecan:aws-skip-validation

Conversation

@awarecan
Copy link
Copy Markdown
Contributor

@awarecan awarecan commented Apr 11, 2019

Description:

Add an option to allow credential skip validation, so that access key do not need IAM.GetUser permission

Related issue (if applicable): fixes #22983

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9196

Example entry for configuration.yaml (if applicable):

aws:
  credentials:
    - name: My AWS Account
      aws_access_key_id: AWS_ID
      aws_secret_access_key: AWS_SECRET
      validate: false

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@github-actions
Copy link
Copy Markdown

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (aws) you are listed as a codeowner for? Thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2019

Codecov Report

Merging #22991 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22991      +/-   ##
==========================================
+ Coverage   93.95%   93.95%   +<.01%     
==========================================
  Files         448      448              
  Lines       36750    36751       +1     
==========================================
+ Hits        34529    34530       +1     
  Misses       2221     2221
Impacted Files Coverage Δ
homeassistant/components/aws/const.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d078e50...972d834. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2019

Codecov Report

Merging #22991 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22991      +/-   ##
==========================================
+ Coverage   93.95%   93.95%   +<.01%     
==========================================
  Files         448      448              
  Lines       36750    36751       +1     
==========================================
+ Hits        34529    34530       +1     
  Misses       2221     2221
Impacted Files Coverage Δ
homeassistant/components/aws/const.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d078e50...b9219d5. Read the comment docs.

@awarecan awarecan merged commit 73a473a into home-assistant:dev Apr 13, 2019
@ghost ghost removed the in progress label Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws component in 0.91.2 appears to require IAM permissions on API key

3 participants