Prevent the projector to toogle on/off

[stbkde]

Prevents the projector to toogle on/off.

Description:

The Epson Projector EH-TW7300 turns on and off with the same command. This minor change fix it.

Checklist:

• [ x] The code change is tested and works locally.
• [ x] Local tests pass with tox.
• [ x] There is no commented out code in this PR.

[homeassistant]

Hi @stbkde,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[pszafer]

According to this #22878 I think it is better to manipulate SUPPORT_EPSON in state attributes.

[andrewsayre]

According to this #22878 I think it is better to manipulate SUPPORT_EPSON in state attributes.

I think submitted approach correct. The referenced PR is to guard against calls that aren't implemented in the device -- not that the current state doesn't allow it. Media player is the exception to the rule that supported_features is to be static.

[andrewsayre]

So if I'm understanding this PR correctly, the constants TURN_ON and TURN_OFF are the same underlying control command hence why we need check the current state of the device before issuing the command to prevent a toggle. If that's correct, this is good to go once build passes.

[pszafer]

@andrewsayre no, TURN_ON and TURN_OFF are not exactly the same.
TURN_OFF is 2 x TURN_OFF in case of projector and have different timeout for waiting for reply.

If you send TURN_ON if it is turned ot projector would probably show info that you need click TURN_ON second time.
If you click TURN_OFF during OFF it will TURN ON projector.

[stbkde]

So if I'm understanding this PR correctly, the constants TURN_ON and TURN_OFF are the same underlying control command hence why we need check the current state of the device before issuing the command to prevent a toggle. If that's correct, this is good to go once build passes.

Correct. TURN_ON and TURN_OFF toggles the power state. This is the easiest way to prevent that for any kind of epson projectors.

[andrewsayre]

I think you're both saying the same thing, just at different levels of abstraction. Are we aligned on this fix?

[pszafer]

It doesn't break anything, so I think it's good to merge.