Skip to content

Bugfix: pass protocol out of header to application layer#22955

Merged
balloob merged 1 commit into
devfrom
ingress-websocket-fix
Apr 10, 2019
Merged

Bugfix: pass protocol out of header to application layer#22955
balloob merged 1 commit into
devfrom
ingress-websocket-fix

Conversation

@pvizeli
Copy link
Copy Markdown
Member

@pvizeli pvizeli commented Apr 9, 2019

Description:

Fix websocket ingress with used protocols they are not pass with header.

@pvizeli pvizeli added this to the 0.91.3 milestone Apr 9, 2019
@ghost ghost assigned pvizeli Apr 9, 2019
@ghost ghost added the in progress label Apr 9, 2019
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2019

Hey there @home-assistant/hass-io, mind taking a look at this pull request as its been labeled with a integration (hassio) you are listed as a codeowner for? Thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2019

Codecov Report

Merging #22955 into dev will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22955      +/-   ##
==========================================
- Coverage   93.84%   93.83%   -0.02%     
==========================================
  Files         449      449              
  Lines       36761    36767       +6     
==========================================
  Hits        34500    34500              
- Misses       2261     2267       +6
Impacted Files Coverage Δ
homeassistant/components/hassio/ingress.py 67.76% <0%> (-3.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48ef7f...93aa0bf. Read the comment docs.

@balloob balloob merged commit 37f3ecc into dev Apr 10, 2019
@ghost ghost removed the in progress label Apr 10, 2019
@delete-merged-branch delete-merged-branch Bot deleted the ingress-websocket-fix branch April 10, 2019 03:13
@pvizeli pvizeli mentioned this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants