Skip to content

Add cloudhook and remote UI vals to get_config#22921

Merged
cgarwood merged 1 commit into
devfrom
mobile_app-add-config-keys
Apr 9, 2019
Merged

Add cloudhook and remote UI vals to get_config#22921
cgarwood merged 1 commit into
devfrom
mobile_app-add-config-keys

Conversation

@robbiet480
Copy link
Copy Markdown
Contributor

@robbiet480 robbiet480 commented Apr 9, 2019

Description:

Adding these keys so that if cloud is added later apps don't have to ask users to type them manually.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

"plz review my smol pr"

@ghost ghost assigned robbiet480 Apr 9, 2019
@ghost ghost added the in progress label Apr 9, 2019
@robbiet480 robbiet480 added this to the 0.91.3 milestone Apr 9, 2019
@Swamp-Ig Swamp-Ig requested review from Swamp-Ig and removed request for Swamp-Ig April 9, 2019 07:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2019

Codecov Report

Merging #22921 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22921      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         448      448              
  Lines       36583    36574       -9     
==========================================
- Hits        34329    34321       -8     
+ Misses       2254     2253       -1
Impacted Files Coverage Δ
homeassistant/components/heos/config_flow.py 100% <0%> (ø) ⬆️
homeassistant/components/stream/worker.py 93.61% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee23bd...a8938ff. Read the comment docs.

@cgarwood cgarwood merged commit 75bed93 into dev Apr 9, 2019
@ghost ghost removed the in progress label Apr 9, 2019
@delete-merged-branch delete-merged-branch Bot deleted the mobile_app-add-config-keys branch April 9, 2019 09:48
@pvizeli pvizeli mentioned this pull request Apr 10, 2019
@KJonline KJonline mentioned this pull request May 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants