More Mobile app sensor fixes#22914
Merged
Merged
Conversation
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## dev #22914 +/- ##
==========================================
+ Coverage 93.83% 93.83% +<.01%
==========================================
Files 448 448
Lines 36578 36574 -4
==========================================
- Hits 34324 34321 -3
+ Misses 2254 2253 -1
Continue to review full report at Codecov.
|
OttoWinter
reviewed
Apr 9, 2019
OttoWinter
approved these changes
Apr 9, 2019
pvizeli
pushed a commit
that referenced
this pull request
Apr 10, 2019
* Ensure we only add a sensor once * Ensure that we dont process updates for entities that arent what we were setup for * Add debug logging to ease development of apps * Use str representation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Discovered an issue where we weren't limiting what previously loaded entities would do with new sensor registrations or sensor updates. This limits things so that only the entity matching the unique ID of the sensor handles its own updates. It also ensures that only one entity handles registering new sensors. Finally, it includes some debug logging to ease development of apps.
Checklist:
tox. Your PR cannot be merged unless tests pass