Skip to content

Added features to Concord232 Alarm Panel#22892

Merged
cgarwood merged 2 commits into
home-assistant:devfrom
AZDane:dev
Apr 9, 2019
Merged

Added features to Concord232 Alarm Panel#22892
cgarwood merged 2 commits into
home-assistant:devfrom
AZDane:dev

Conversation

@AZDane
Copy link
Copy Markdown
Contributor

@AZDane AZDane commented Apr 8, 2019

Description:

Adds functionality to Concord232 Alarm Panel. 2 additional attributes can be defined in configuration.yaml. 'code' which allows for defining a code and 'mode' which allows for silent activation of the ARM HOME option

Currently Concord232 Server can Arm/Disarm without providing code or by providing wrong code. Updated code adds functionality to define a code in configuration.yaml.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9173

Example entry for configuration.yaml (if applicable):

alarm_control_panel:
  - platform: concord232
     host: 192.168.1.11
     code: 1234
     mode: silent

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Comment thread homeassistant/components/concord232/alarm_control_panel.py Outdated
Copy link
Copy Markdown
Contributor Author

@AZDane AZDane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted 'or None' and committed the change

@cgarwood cgarwood merged commit d48fe4c into home-assistant:dev Apr 9, 2019
@ghost ghost removed the in progress label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants