Add ESPHome climate support#22859
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
awarecan
left a comment
There was a problem hiding this comment.
away_mode is an optional, so that we need check if this feature enabled before send command
@awarecan What do you mean by that? The state attribute is already filtered here: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/climate/__init__.py#L267 |
|
There is no filter when call |
|
For away mode command, that should ultimately be handled in climate base? Anyway, attempting to send an away command would just result in a warning in the esphome log like "This climate device does not support setting away mode". ESPHome also does validation of commands on the esp side, so that's not a problem. I'll wait for #22878 and then apply the same things for climate in the base. |
|
22878 merged. |
|
Should we merge? |
Description:
Adds climate device support for esphome. Not much happening here, service calls are just forwarded and state is received as usual
Checklist:
tox. Your PR cannot be merged unless tests passPlz ... merge my PR for 0.92 ... 💛