Conversation
Member
There was a problem hiding this comment.
Instead of using hasattr, it would be better suited whem implemented as properties with default values.
@property
def min_temp(self):
self.hass.config.temperature(7, TEMP_CELCIUS)[0]
def state_attributes(self):
[…]
data[ATTR_MIN_TEMP] = self.min_tempAny implementing thermostat would then just overwrite the min_temp property. This approach is in line with how other data is passed around within thermostats (for example is_away_mode_on)
Member
|
When this is merged I'll merge home-assistant/frontend#3 and compile new version of frontend. |
balloob
added a commit
that referenced
this pull request
Jul 24, 2015
Custom min/max temperature for thermostat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to customize the min max temperature for the thermostat.
See also home-assistant/frontend#3