Fix trend binary sensor and tests#22686
Merged
Merged
Conversation
homeassistant
added
has-tests
cla-signed
integration: trend
small-pr
ghost
assigned
balloob
approved these changes
Apr 3, 2019
Member
|
Flaky test is homekit controller, fixed in another branch. |
jonbeckman
pushed a commit
to jonbeckman/home-assistant
that referenced
this pull request
Apr 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Trend binary sensor has the capability to calculate the state base one trend line. It is time-sensitive calculation, so the sample time should be the update_time of the entity's state, not the time trend sensor received sample.
Also, the test also time-sensitive, it may become flaky since everytime I run I got different numbers. This PR changed test to control the timing. Now I get more stable result.
One flaky test result I spotted at here: https://circleci.com/gh/home-assistant/home-assistant/3728#tests/containers/1
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: