Skip to content

Fix citybikes#22683

Merged
balloob merged 1 commit intohome-assistant:devfrom
MartinHjelmare:fix-citybikes
Apr 3, 2019
Merged

Fix citybikes#22683
balloob merged 1 commit intohome-assistant:devfrom
MartinHjelmare:fix-citybikes

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented Apr 3, 2019

Breaking Change:

N/A

Description:

  • Move asyncio condition to instance from class, to be able to pass in
    loop.
  • Avoid not needed side effects in init methods.
  • Clean up.

Related issue (if applicable):
fixes #16523

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: citybikes
    network: velib
    stations:
      - 19008
  - platform: citybikes
    network: velib
    stations:
      - 19001

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

* Move asyncio condition to instance from class, to be able to pass in
  lopp.
* Avoid not needed sife effects in init methods.
* Clean up.
@ghost ghost assigned MartinHjelmare Apr 3, 2019
@ghost ghost added the in progress label Apr 3, 2019
@balloob balloob merged commit 3872ac9 into home-assistant:dev Apr 3, 2019
@ghost ghost removed the in progress label Apr 3, 2019
@MartinHjelmare MartinHjelmare deleted the fix-citybikes branch April 4, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Citybike sensor error

3 participants