Google Assistant: Add support for open/close binary sensors#22674
Merged
Conversation
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## dev #22674 +/- ##
==========================================
+ Coverage 93.83% 93.83% +<.01%
==========================================
Files 449 449
Lines 36558 36568 +10
==========================================
+ Hits 34305 34315 +10
Misses 2253 2253
Continue to review full report at Codecov.
|
awarecan
reviewed
Apr 3, 2019
| } | ||
|
|
||
| calls = async_mock_service( | ||
| hass, cover.DOMAIN, cover.SERVICE_SET_COVER_POSITION) |
Contributor
There was a problem hiding this comment.
Why test a trait about binary_sensor cannot open a cover?
Member
|
I think we need to add docs for this PR correct? |
jonbeckman
pushed a commit
to jonbeckman/home-assistant
that referenced
this pull request
Apr 7, 2019
…istant#22674) * Google Assistant: Add support for binary sensors * Update test
elupus
pushed a commit
to elupus/home-assistant
that referenced
this pull request
Apr 16, 2019
…istant#22674) * Google Assistant: Add support for binary sensors * Update test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add support for binary sensors that represent open/closed. Allows users to ask "Hey Google, is my X open?"
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: