Skip to content

Deal with cover assumed state#22673

Merged
pvizeli merged 2 commits intodevfrom
cover-assumed
Apr 3, 2019
Merged

Deal with cover assumed state#22673
pvizeli merged 2 commits intodevfrom
cover-assumed

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 3, 2019

Description:

When a cover has an assumed state, we will always report the state as "50%" open. That way both commands can always be issued.

I've reached out to Google to ask if they can add support for commandOnlyOnOff to the OpenClose trait, like they have for the OnOff trait.

Related issue (if applicable): fixes #22672

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.91.0 milestone Apr 3, 2019
@ghost ghost assigned balloob Apr 3, 2019
@ghost ghost added the in progress label Apr 3, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2019

Codecov Report

Merging #22673 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22673      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         449      449              
  Lines       36551    36536      -15     
==========================================
- Hits        34296    34283      -13     
+ Misses       2255     2253       -2
Impacted Files Coverage Δ
homeassistant/components/google_assistant/trait.py 96.28% <100%> (+0.48%) ⬆️
homeassistant/components/deconz/config_flow.py 97.72% <0%> (-0.24%) ⬇️
homeassistant/helpers/config_validation.py 95.46% <0%> (-0.03%) ⬇️
homeassistant/components/heos/config_flow.py 100% <0%> (ø) ⬆️
homeassistant/components/deconz/const.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f294152...0014c37. Read the comment docs.

@pvizeli pvizeli merged commit b1cca25 into dev Apr 3, 2019
@ghost ghost removed the in progress label Apr 3, 2019
@delete-merged-branch delete-merged-branch Bot deleted the cover-assumed branch April 3, 2019 11:53
balloob added a commit that referenced this pull request Apr 3, 2019
* Deal with cover assumed state

* Add docs
@balloob balloob mentioned this pull request Apr 3, 2019
jonbeckman pushed a commit to jonbeckman/home-assistant that referenced this pull request Apr 7, 2019
* Deal with cover assumed state

* Add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stateless Cover open/close issue in Google Assistant Cloud Component

3 participants