Conversation
Codecov Report
@@ Coverage Diff @@
## dev #22673 +/- ##
==========================================
+ Coverage 93.83% 93.83% +<.01%
==========================================
Files 449 449
Lines 36551 36536 -15
==========================================
- Hits 34296 34283 -13
+ Misses 2255 2253 -2
Continue to review full report at Codecov.
|
pvizeli
approved these changes
Apr 3, 2019
balloob
added a commit
that referenced
this pull request
Apr 3, 2019
* Deal with cover assumed state * Add docs
Merged
jonbeckman
pushed a commit
to jonbeckman/home-assistant
that referenced
this pull request
Apr 7, 2019
* Deal with cover assumed state * Add docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When a cover has an assumed state, we will always report the state as "50%" open. That way both commands can always be issued.
I've reached out to Google to ask if they can add support for
commandOnlyOnOffto the OpenClose trait, like they have for theOnOfftrait.Related issue (if applicable): fixes #22672
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: