Skip to content

Shutdown ZHAGateway on hass closing.#22646

Merged
Adminiuga merged 2 commits intohome-assistant:devfrom
Adminiuga:fixes/zha-shutdown
Apr 3, 2019
Merged

Shutdown ZHAGateway on hass closing.#22646
Adminiuga merged 2 commits intohome-assistant:devfrom
Adminiuga:fixes/zha-shutdown

Conversation

@Adminiuga
Copy link
Copy Markdown
Contributor

Description:

Refactor ZHA component unloading/shutdown.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@Adminiuga Adminiuga requested a review from dmulcahey as a code owner April 1, 2019 23:05
@ghost ghost assigned Adminiuga Apr 1, 2019
@ghost ghost added the in progress label Apr 1, 2019
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge when build passes.

@Adminiuga Adminiuga force-pushed the fixes/zha-shutdown branch 3 times, most recently from b2b4911 to 0588707 Compare April 2, 2019 22:46
@Adminiuga Adminiuga force-pushed the fixes/zha-shutdown branch from 0588707 to beb0010 Compare April 3, 2019 01:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2019

Codecov Report

Merging #22646 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22646      +/-   ##
==========================================
- Coverage   93.82%   93.82%   -0.01%     
==========================================
  Files         449      449              
  Lines       36536    36534       -2     
==========================================
- Hits        34281    34279       -2     
  Misses       2255     2255
Impacted Files Coverage Δ
homeassistant/components/heos/config_flow.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d93a7...beb0010. Read the comment docs.

@Adminiuga Adminiuga merged commit 625c8e0 into home-assistant:dev Apr 3, 2019
@ghost ghost removed the in progress label Apr 3, 2019
@Adminiuga Adminiuga deleted the fixes/zha-shutdown branch April 3, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed integration: zha small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants