Require static-check success first for rest of workflow#22635
Merged
Conversation
ghost
assigned
Contributor
Author
|
|
delete-merged-branch
Bot
deleted the
awarecan-circle-ci-require-static-check
branch
Member
|
@Jc2k looks like your recently introduced Lennox30 test is flaky, see tests for this build: https://circleci.com/gh/home-assistant/home-assistant/2686?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
balloob
pushed a commit
that referenced
this pull request
Apr 3, 2019
* Require static-check success first * Update config.yml
Merged
jonbeckman
pushed a commit
to jonbeckman/home-assistant
that referenced
this pull request
Apr 7, 2019
…nt#22635) * Require static-check success first * Update config.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Allow fail build earlier if there was a syntax and format issue caught by our static check, e.g. flake8 and gen_requirements script