Skip to content

Config CircleCI workflow#22590

Merged
awarecan merged 2 commits intodevfrom
awarecan-circle-ci
Apr 1, 2019
Merged

Config CircleCI workflow#22590
awarecan merged 2 commits intodevfrom
awarecan-circle-ci

Conversation

@awarecan
Copy link
Copy Markdown
Contributor

@awarecan awarecan commented Mar 31, 2019

Description:

Continue to config CircleCI to fill the gap between circle and travis

  • Add mypy
  • Add lokalise.co
  • Add status badge
  • Use python 3.5 for lint
  • [won't fix] Use python 3.5.3 instead 3.5.5

Related issue (if applicable): fixes #

@ghost ghost assigned awarecan Mar 31, 2019
@ghost ghost added the in progress label Mar 31, 2019
@awarecan awarecan force-pushed the awarecan-circle-ci branch 2 times, most recently from 387b1c4 to 79385ab Compare March 31, 2019 21:13
@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 31, 2019

Don't worry about using Python 3.5.3, especially 3.5 is on its way out anyway.

@awarecan awarecan force-pushed the awarecan-circle-ci branch 2 times, most recently from ab74ac4 to 52c6e8a Compare April 1, 2019 03:03
@awarecan awarecan force-pushed the awarecan-circle-ci branch 5 times, most recently from 4971c0a to d5da1ee Compare April 1, 2019 07:54
@awarecan awarecan marked this pull request as ready for review April 1, 2019 07:55
@awarecan
Copy link
Copy Markdown
Contributor Author

awarecan commented Apr 1, 2019

I also tweaked parallelism to 2 from 3. It would allow more flexible arrangement of containers. We have only total 4 containers for now. parallelism: 2 will allow we have two test jobs running concurrently.

Translation upload only executed on dev branch, so it would not be execute in checks of this PR. I have a success upload before see https://circleci.com/gh/home-assistant/home-assistant/2052. I hacked the trigger branch for testing purpose.

@awarecan
Copy link
Copy Markdown
Contributor Author

awarecan commented Apr 1, 2019

travis confused when I change PR from draft to ready to review. I will make another force push to refresh it

@awarecan awarecan force-pushed the awarecan-circle-ci branch from d5da1ee to aea6e5d Compare April 1, 2019 08:03
Copy link
Copy Markdown
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awarecan awarecan merged commit de4d1f2 into dev Apr 1, 2019
@delete-merged-branch delete-merged-branch Bot deleted the awarecan-circle-ci branch April 1, 2019 14:13
@ghost ghost removed the in progress label Apr 1, 2019
@balloob balloob added this to the 0.91.0 milestone Apr 3, 2019
balloob pushed a commit that referenced this pull request Apr 3, 2019
* Add mypyrc to control typing check, add mypy to circle

* Add translation upload circlci job
@balloob balloob mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants