Add mobile_app notify platform#22580
Merged
Merged
Conversation
ghost
assigned
robbiet480
force-pushed
the
mobile_app-notify
branch
from
2360a24 to
aef5e43
Compare
balloob
reviewed
Mar 31, 2019
balloob
reviewed
Mar 31, 2019
balloob
reviewed
Mar 31, 2019
balloob
reviewed
Mar 31, 2019
balloob
reviewed
Mar 31, 2019
balloob
reviewed
Mar 31, 2019
balloob
reviewed
Mar 31, 2019
balloob
reviewed
Mar 31, 2019
balloob
reviewed
Mar 31, 2019
Contributor
Author
|
Tests failing due to flaky |
balloob
reviewed
Apr 1, 2019
balloob
reviewed
Apr 1, 2019
Contributor
Author
|
Test added |
awarecan
reviewed
Apr 3, 2019
awarecan
reviewed
Apr 3, 2019
balloob
pushed a commit
that referenced
this pull request
Apr 3, 2019
* Add mobile_app notify platform * Requested changes * Fix incorrect param for status code * Move push_registrations to notify platform file * Trim down registration information sent in push * quotes * Use async version of load_platform * Add warning for duplicate device names * Switch to async_get_service * add mobile_app.notify test * Update tests/components/mobile_app/test_notify.py * Update tests/components/mobile_app/test_notify.py
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds a generic
mobile_appnotification platform.push_urlandpush_tokenmust be set in the app data dictionary to enable the platform for a registration.Checklist:
tox. Your PR cannot be merged unless tests pass