Fix gtfs typing and logger issues #22572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MartinHjelmare
changed the title
renemarc
force-pushed
the
gtfs-code-cleanup
branch
from
af69095 to
cf20e68
Compare
|
Please don't squash commits after review has started to make it easier for readers to track changes. |
MartinHjelmare
approved these changes
Mar 31, 2019
|
Can be merged when build passes. |
3 tasks
unibeck
pushed a commit
to unibeck/home-assistant
that referenced
this pull request
Apr 7, 2019
## Description: Some code cleanup requests where raised in the [latest merged GTFS commit](home-assistant@9153e3b). This new PR aims to address them, including: - Clear all typing issues. - Respect logger levels and format. - Simplify some non-pythonic lines. This sensor now passes `mypy` testing, but does so by ignoring two lines with `# type: ignore`. **Related issue (if applicable):** fixes issues raised by @MartinHjelmare in home-assistant#20966 ## Checklist: - [x] The code change is tested and works locally. - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass** - [x] There is no commented out code in this PR. [ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard/__init__.py#L14 [ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard/__init__.py#L23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some code cleanup requests where raised in the latest merged GTFS commit. This new PR aims to address them, including:
This sensor now passes
mypytesting, but does so by ignoring two lines with# type: ignore.Related issue (if applicable): fixes issues raised by @MartinHjelmare in #20966
Checklist:
tox. Your PR cannot be merged unless tests pass