Added features to Concord232 Alarm Panel#22411
Closed
AZDane wants to merge 5 commits intohome-assistant:devfrom
AZDane:dev
Closed
Added features to Concord232 Alarm Panel#22411AZDane wants to merge 5 commits intohome-assistant:devfrom AZDane:dev
AZDane wants to merge 5 commits intohome-assistant:devfrom
AZDane:dev
Conversation
Added ability to define code and mode in configuration.yaml code (string)(Optional) If defined, specifies a code to enable or disable the alarm in the frontend. Only one of code and code_template can be specified. mode (string)(Optional) audible/silent if defined, specifies wether Alarm Panel should be audible or silent when armed in Home Mode. Default Value: audible
Currently concord232 arms and disarms panel regardless of code entry (none/random) Changes ads ability to define code in configuration.yaml. Additionally ability to arm panel silent has been added. code (string)(Optional) If defined, specifies a code to enable or disable the alarm in the frontend. mode (string)(Optional) audible/silent if defined, specifies wether Alarm Panel should be audible or silent when armed in Home Mode. Default Value: audible
Deleted Trailing White Space
Contributor
Contributor
Author
|
Documentation added/updated in home-assistant/home-assistant.io#9039 |
2 tasks
wrong indention of add_entities(sensors, True) caused same sensor to be added multiple times since it was placed inside loop
Contributor
Author
|
Added concord binary sensor to the request since it contains an error causing same sensor to be added multiple times |
Further simplification. Ok. I will stop now :)
Contributor
|
Please rebase your branch to get our new CI configuration to your branch, or create a new branch base on current If you choose rebase, following are some basic git command # in your branch do
git remote add upstream https://github.com/home-assistant/home-assistant.git
git fetch upstream
git rebase upstream/dev
git push -f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Adds functionality to Concord232 Alarm Panel. 2 additional attributes can be defined in configuration.yaml. 'code' which allows for defining a code and 'mode' which allows for silent activation of the ARM HOME option
Currently Concord232 Server can Arm/Disarm without providing code or by providing wrong code. Updated code adds functionality to define a code in configuration.yaml.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9039
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: