Add additional needles to glances cpu_temp attribute

[shutupflanders]

Description:

Added additional keys in the section that checks for the "cpu_temp" attribute from the Glances API with a fallback to "Core 0" to at least provide some temperature information.

Checklist:

• [ Y] The code change is tested and works locally.
• [ Y] Local tests pass with tox. Your PR cannot be merged unless tests pass
• [ Y] There is no commented out code in this PR.

[fabaff]

On which hardware/architecture does this occur? I though that by now we have covered all available CPU architectures...

[shutupflanders]

I have a gigabyte brix and a Lenovo q180, couldn't tell you the architecture off the top of my head, but in testing it pulled through both, whereas I was getting a blank value on the main release

[fabaff]

This should be ordinary hardware (x86_64). Both should expose the temperature through Package id 0.

What do you get if you run?

$ curl http://IP_ADDRESS:61208/api/3/sensors

[shutupflanders]

I get Core 0, Core 1, and one of the other strings I've added depending on which box I run it against, I only get Package 0 on my NUC

[shutupflanders]

I'll drop the full responses in later when I'm at my desk

[shutupflanders]

Here's the response from the sensors endpoint on 3 of my machines that were reporting nothing prior to my changes:

Q180

[
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 74,
    "label": "Core 0"
  },
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 73,
    "label": "Core 1"
  },
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 68,
    "label": "radeon 1"
  }
]

Proxmox server (Ryzen 7)

[
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 23,
    "label": "amdgpu 1"
  }
]

Brix (Core 0 fallback needed for this)

[
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 26,
    "label": "acpitz 1"
  },
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 39,
    "label": "Core 0"
  },
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 39,
    "label": "Core 1"
  },
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 41,
    "label": "Core 2"
  },
  {
    "key": "label",
    "type": "temperature_core",
    "unit": "C",
    "value": 41,
    "label": "Core 3"
  }
]

If you need any more info, please let me know.

[shutupflanders]

Also, I added both my email accounts to my github, but the cla error hasn't gone away, not sure if that's set to check again or if it's a manual thing I'm supposed to trigger?

[homeassistant]

Hi @shutupflanders,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[balloob]

@fabaff can you make a decision what to do with this PR, can we merge, do we require changes or do we not want this change?

[balloob]

@fabaff ?

[MartinHjelmare]

What should we do here? This is six months old.

[balloob]

I pinged @fabaff on Discord

[fabaff]

Can be merged after the conflict is solved.