Update vizio component to support latest pyvizio with soundbar support#22294
Update vizio component to support latest pyvizio with soundbar support#22294MartinHjelmare merged 26 commits intohome-assistant:devfrom raman325:dev
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #22294 +/- ##
==========================================
- Coverage 93.84% 93.83% -0.01%
==========================================
Files 449 449
Lines 36568 36568
==========================================
- Hits 34317 34314 -3
- Misses 2251 2254 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #22294 +/- ##
=========================================
- Coverage 94.2% 94.19% -0.01%
=========================================
Files 453 453
Lines 36913 36913
=========================================
- Hits 34773 34772 -1
- Misses 2140 2141 +1
Continue to review full report at Codecov.
|
MartinHjelmare
left a comment
There was a problem hiding this comment.
Can be merged when last comments are addressed and build passes.
Codecov Report
@@ Coverage Diff @@
## dev #22294 +/- ##
==========================================
+ Coverage 94.19% 94.19% +<.01%
==========================================
Files 453 453
Lines 36915 36915
==========================================
+ Hits 34772 34773 +1
+ Misses 2143 2142 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #22294 +/- ##
==========================================
+ Coverage 94.19% 94.19% +<.01%
==========================================
Files 453 453
Lines 36915 36915
==========================================
+ Hits 34772 34773 +1
+ Misses 2143 2142 -1
Continue to review full report at Codecov.
|
Description:
The pyvizio package and HA component were originally built with TV's in mind. They both technically supported sound bars but the support was hacky. These changes make sound bars a first class citizen for the component along with TV's.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9005
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: