Skip to content

Update vizio component to support latest pyvizio with soundbar support#22294

Merged
MartinHjelmare merged 26 commits intohome-assistant:devfrom
raman325:dev
Apr 18, 2019
Merged

Update vizio component to support latest pyvizio with soundbar support#22294
MartinHjelmare merged 26 commits intohome-assistant:devfrom
raman325:dev

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Mar 22, 2019

Description:

The pyvizio package and HA component were originally built with TV's in mind. They both technically supported sound bars but the support was hacky. These changes make sound bars a first class citizen for the component along with TV's.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9005

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: vizio
    host: IP_ADDRESS
    access_token: AUTH_TOKEN
    device_class: tv

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [N/A] New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2019

Codecov Report

Merging #22294 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22294      +/-   ##
==========================================
- Coverage   93.84%   93.83%   -0.01%     
==========================================
  Files         449      449              
  Lines       36568    36568              
==========================================
- Hits        34317    34314       -3     
- Misses       2251     2254       +3
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.73% <0%> (-3.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85bcce...b157802. Read the comment docs.

Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2019

Codecov Report

Merging #22294 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev   #22294      +/-   ##
=========================================
- Coverage   94.2%   94.19%   -0.01%     
=========================================
  Files        453      453              
  Lines      36913    36913              
=========================================
- Hits       34773    34772       -1     
- Misses      2140     2141       +1
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.68% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ca9ca...f21693a. Read the comment docs.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when last comments are addressed and build passes.

Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2019

Codecov Report

Merging #22294 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22294      +/-   ##
==========================================
+ Coverage   94.19%   94.19%   +<.01%     
==========================================
  Files         453      453              
  Lines       36915    36915              
==========================================
+ Hits        34772    34773       +1     
+ Misses       2143     2142       -1
Impacted Files Coverage Δ
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77244ea...1096f66. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2019

Codecov Report

Merging #22294 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22294      +/-   ##
==========================================
+ Coverage   94.19%   94.19%   +<.01%     
==========================================
  Files         453      453              
  Lines       36915    36915              
==========================================
+ Hits        34772    34773       +1     
+ Misses       2143     2142       -1
Impacted Files Coverage Δ
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77244ea...a85fe41. Read the comment docs.

@MartinHjelmare MartinHjelmare merged commit 620c6a2 into home-assistant:dev Apr 18, 2019
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants