Skip to content

Wink sensors#22

Merged
balloob merged 11 commits intohome-assistant:devfrom
kangaroo:wink-sensors
Jan 20, 2015
Merged

Wink sensors#22
balloob merged 11 commits intohome-assistant:devfrom
kangaroo:wink-sensors

Conversation

@kangaroo
Copy link
Copy Markdown
Contributor

Rebasing on dev due to timer changes.
Again, ideally wink will give us push, polling doors even on 3s, sucks.

balloob and others added 11 commits January 13, 2015 08:25
* dev:
  Exclude external libraries from code coverage
  Bug fixes for Wink
  Better positioning of dialogs
  Added error handling in frontend debug forms
  Integrate add worker to bootstrap.setup_component
  Conditionally show widgets on light more info
  Rename the edit state button in more info to debug
  Expect devices to have no name
Refactor wink API fetching into a generic 'get_devices' function.
Hook up to scan sensor_pod_id's from Wink and report their status.
@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 20, 2015

Added you as a collaborator on the project. Trying out something I read.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.96%) when pulling abfaca3 on kangaroo:wink-sensors into 869c4eb on balloob:dev.

balloob added a commit that referenced this pull request Jan 20, 2015
@balloob balloob merged commit 9d933f5 into home-assistant:dev Jan 20, 2015
@kangaroo
Copy link
Copy Markdown
Contributor Author

Bah, now you called me out on my original one :)

That said, working on the rest of the pylint/flake8/etc requirements. But, working on a rpi for this project, will take a few.

@kangaroo
Copy link
Copy Markdown
Contributor Author

Also, to be fair, I did open the original one as a discussion point for the sensor base. :)

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 20, 2015

Oh, you didn't want it to be merged yet, it seemed like mvp was done, no?

@kangaroo
Copy link
Copy Markdown
Contributor Author

MVP was enough, its ok. It just happened that I was working on requirements.txt in the background gated by rpi clock cycles. :)

@kangaroo
Copy link
Copy Markdown
Contributor Author

Self-judgement, not project-judgement. :)

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
MoonDevLT added a commit to MoonDevLT/core that referenced this pull request Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants