Rebrand Cisco Spark notify to be Cisco Webex Teams#21938
Rebrand Cisco Spark notify to be Cisco Webex Teams#21938robbiet480 merged 16 commits intohome-assistant:devfrom fbradyirl:sparkRebrand
Conversation
|
cc @shenning00 |
|
The only breaking change to the config is the platform name. What do we think about retaining the old platform but updating it to print a deprecation warning and then import the new platform's logic? Not sure how feasible that is, but, it would give folks time to adjust their config before things break. @balloob thoughts? |
Personally, I would be in favour of a clean break. The user would see in the logs that the platform doesn't exist, and go from there. However, I am not against a type of platform deprecation if such a method exists, or has happened in the past? |
|
You can leave a mock spark platform, only purpose of it is to print out warning message with how to migrate instruction. |
|
would there be a way to tell the user via Notification Center? Or must we rely on them checking the logs? |
|
The error message can be trigger by schema validation, that is in very early stage of start up, user can also validate their current config by our command line script, and even before they upgraded by hassio check config add-on So, a configuration validation error is better IMO. |
|
Are folks happy with this PR or do you require changes? |
|
Please rebase on latest dev and solve the merge conflict. |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! Add the component package to .coveragerc, and see my comment below.
Can be merged when build passes and those things are fixed.
|
We should remove the breaking change label, right? |
|
Still breaking change? |
|
Nope, @MartinHjelmare already said we could remove the label |
Description:
Since
ciscosparkapipypi will be unsupported towards the end of 2019, it is a good idea to move to the replacementwebexteamssdkpypi module.Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8919
Example entry for
configuration.yaml:Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: