Skip to content

Fix race condition in ADS hub#21677

Merged
MartinHjelmare merged 7 commits into
home-assistant:devfrom
carstenschroeder:ads-race-condition-patch
Mar 5, 2019
Merged

Fix race condition in ADS hub#21677
MartinHjelmare merged 7 commits into
home-assistant:devfrom
carstenschroeder:ads-race-condition-patch

Conversation

@carstenschroeder
Copy link
Copy Markdown
Contributor

Fixes race condition that sporadically lead to ADS entity values not showing up.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost added the in progress label Mar 5, 2019
@carstenschroeder
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare Could you have a look? This fixes a nasty error.

@MartinHjelmare MartinHjelmare merged commit 17c3c14 into home-assistant:dev Mar 5, 2019
@ghost ghost removed the in progress label Mar 5, 2019
@MartinHjelmare MartinHjelmare added this to the 0.89.0 milestone Mar 5, 2019
@carstenschroeder carstenschroeder deleted the ads-race-condition-patch branch March 5, 2019 10:20
balloob pushed a commit that referenced this pull request Mar 5, 2019
@balloob balloob mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants