Skip to content

Add person support for Waze Travel Time#21471

Merged
balloob merged 1 commit into
home-assistant:devfrom
Petro31:patch-7
Feb 27, 2019
Merged

Add person support for Waze Travel Time#21471
balloob merged 1 commit into
home-assistant:devfrom
Petro31:patch-7

Conversation

@Petro31
Copy link
Copy Markdown
Contributor

@Petro31 Petro31 commented Feb 27, 2019

Adds person to the list of TRACKABLE_DOMAINS domains. _get_location_from_entity will handle the person domain without any changes.

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Adds person to the list of TRACKABLE_DOMAINS domains.  _get_location_from_entity will handle the person domain without any changes.
@ghost ghost added the in progress label Feb 27, 2019
Petro31 added a commit to Petro31/home-assistant.io that referenced this pull request Feb 27, 2019
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this change.

It would have been nice if users would have been able to define either an origin_entity or an origin_text, so that we didn't had to filter on trackable domains. I would expect any entity with a location to be allowed to use really.

@balloob balloob merged commit 51773f3 into home-assistant:dev Feb 27, 2019
@ghost ghost removed the in progress label Feb 27, 2019
balloob pushed a commit to home-assistant/home-assistant.io that referenced this pull request Feb 27, 2019
@Petro31
Copy link
Copy Markdown
Contributor Author

Petro31 commented Feb 27, 2019

@balloob Yes, I agree. I'll look into making those changes. I wanted to refactor this to fit the new component model too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants