Add person support for Waze Travel Time#21471
Merged
Merged
Conversation
Adds person to the list of TRACKABLE_DOMAINS domains. _get_location_from_entity will handle the person domain without any changes.
Petro31
added a commit
to Petro31/home-assistant.io
that referenced
this pull request
Feb 27, 2019
2 tasks
balloob
approved these changes
Feb 27, 2019
Member
balloob
left a comment
There was a problem hiding this comment.
Fine with this change.
It would have been nice if users would have been able to define either an origin_entity or an origin_text, so that we didn't had to filter on trackable domains. I would expect any entity with a location to be allowed to use really.
balloob
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Feb 27, 2019
Contributor
Author
|
@balloob Yes, I agree. I'll look into making those changes. I wanted to refactor this to fit the new component model too. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds person to the list of TRACKABLE_DOMAINS domains. _get_location_from_entity will handle the person domain without any changes.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: