Move Broadlink services to component by elupus · Pull Request #21465 · home-assistant/core

elupus · 2019-02-26T21:54:59Z

Description:

Move broadlink to separate component including services to new domain.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8989

Example entry for `configuration.yaml` (if applicable):

switch:
  - platform: broadlink
    host: 192.168.0.2
    mac: '11:22:33:44:55:66'
    type: rm2
    switches:
     tv:
       command_on    : 'JgBGAJKVETkRORA6ERQRFBEUERQRFBE5ETkQOhAVEBUQFREUEBUQOhEUERQRORE5EBURFBA6EBUQOhE5EBUQFRA6EDoRFBEADQUAAA=='
       command_off   : 'JgBGAJOVEDoQOhA6DxYPFhAVEBUQFRA6ETkROREUERQRFBEUEBUQFREUERQRORE5EBUQFRE5ETkRORE5ERUQFRA6DzsPFhAADQUAAA=='

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

~~New dependencies have been added to the REQUIREMENTS variable (example).~~
~~New dependencies are only imported inside functions that use them (example).~~
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

elupus · 2019-02-26T21:56:25Z

This is WIP. I ended up splitting a larger refactor into just the move and the service change first. That way the diff ends up much smaller for the full refactor.

I only have an rm2 device, so can't test any of the other device. Will need help on that at some point.

stsybizov · 2019-02-27T08:15:48Z

I can help you with test. I have:

RM2 Pro+
RM Mini
SP3
A1
TC2

elupus · 2019-03-05T15:37:22Z

@stsybizov can you give it a go on at least an SP3 device?

stsybizov · 2019-03-06T08:14:03Z

@elupus sure, give me file for test

elupus · 2019-03-12T16:07:08Z

@stsybizov did you mean config by file? I can't really give you that since i don't know your device parameters. That said. i don't think this pull needs that testing. If i continue the refactor it might be needed.

elupus · 2019-03-20T15:48:53Z

This should be good to go now.

codecov · 2019-04-06T21:14:17Z

Codecov Report

Merging #21465 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev   #21465      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         448      449       +1     
  Lines       36529    36533       +4     
==========================================
+ Hits        34276    34280       +4     
  Misses       2253     2253

Impacted Files	Coverage Δ
homeassistant/components/broadlink/const.py	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a747eaa...0c5bfcb. Read the comment docs.

codecov · 2019-04-06T21:14:17Z

Codecov Report

Merging #21465 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev   #21465      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         448      449       +1     
  Lines       36529    36533       +4     
==========================================
+ Hits        34276    34280       +4     
  Misses       2253     2253

Impacted Files	Coverage Δ
homeassistant/components/broadlink/const.py	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a747eaa...1161f15. Read the comment docs.

MartinHjelmare

Looks good!

MartinHjelmare · 2019-04-26T08:07:03Z

We forgot to label this a breaking change and write a release note paragraph. 😢

elupus requested a review from Danielhiversen as a code owner February 26, 2019 21:55

homeassistant added cla-signed integration: broadlink labels Feb 26, 2019

ghost added the in progress label Feb 26, 2019

elupus closed this Feb 28, 2019

ghost removed the in progress label Feb 28, 2019

elupus reopened this Feb 28, 2019

ghost added the in progress label Feb 28, 2019

elupus changed the title ~~WIP: Broadlink componentization~~ RFC: Broadlink componentization Mar 5, 2019

houndci-bot reviewed Mar 6, 2019

View reviewed changes

Comment thread tests/components/broadlink/test_init.py

houndci-bot reviewed Mar 11, 2019

View reviewed changes

Comment thread tests/components/broadlink/test_init.py Outdated

Comment thread tests/components/broadlink/test_init.py

elupus mentioned this pull request Mar 12, 2019

Add Broadlink-wifi climate support #21962

Closed

7 tasks

elupus closed this Mar 13, 2019

elupus reopened this Mar 13, 2019

ghost added in progress and removed in progress labels Mar 13, 2019

elupus force-pushed the broadlink_component branch from ed0e0fe to 578dd03 Compare March 18, 2019 22:34

houndci-bot reviewed Mar 18, 2019

View reviewed changes

elupus force-pushed the broadlink_component branch from 578dd03 to e2c8887 Compare March 18, 2019 22:38

elupus changed the title ~~RFC: Broadlink componentization~~ Broadlink services moved to component Mar 18, 2019

elupus mentioned this pull request Mar 20, 2019

Update broadlink switch documentation with new location of service home-assistant/home-assistant.io#8989

Merged

2 tasks

MartinHjelmare requested changes Apr 3, 2019

View reviewed changes

elupus added 2 commits April 6, 2019 22:11

Register services in broadlink domain

c6e64f6

Add tests for broadlink services

1672d71

Resolve review comments

2cfdedf

elupus force-pushed the broadlink_component branch from e2c8887 to 2cfdedf Compare April 6, 2019 20:27

One more review fix

0c5bfcb

MartinHjelmare reviewed Apr 10, 2019

View reviewed changes

Comment thread homeassistant/components/broadlink/__init__.py Outdated

elupus added 3 commits April 10, 2019 11:34

Restore auth retry

ef97cb8

Drop unused constants

2324d3b

Fix flake8 errors

1161f15

MartinHjelmare approved these changes Apr 12, 2019

View reviewed changes

MartinHjelmare changed the title ~~Broadlink services moved to component~~ Move Broadlink services to component Apr 12, 2019

MartinHjelmare merged commit 0a3e11a into home-assistant:dev Apr 12, 2019

ghost removed the in progress label Apr 12, 2019

smartHomeHub mentioned this pull request Apr 25, 2019

SmartIR latest version incompatible with Home Assistant? smartHomeHub/SmartIR#104

Closed

elupus deleted the broadlink_component branch May 2, 2019 11:04

tdejneka mentioned this pull request Jun 1, 2019

Switch template. Failed to call service switch/turn_on. Service not found. #24148

Closed

bmfurtado mentioned this pull request Oct 7, 2019

Fix broadlink.learn failure on RM devices #27274

Closed

9 tasks

Uh oh!

Conversation

elupus commented Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

elupus commented Feb 26, 2019

Uh oh!

stsybizov commented Feb 27, 2019

Uh oh!

elupus commented Mar 5, 2019

Uh oh!

stsybizov commented Mar 6, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elupus commented Mar 12, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elupus commented Mar 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 6, 2019

Codecov Report

Uh oh!

codecov Bot commented Apr 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

elupus commented Feb 26, 2019 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

codecov Bot commented Apr 6, 2019 •

edited

Loading