Skip to content

Push pyads to 3.0.7 #21216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 7 commits into from
Feb 19, 2019
Merged

Push pyads to 3.0.7 #21216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9bb22ed
Merge pull request #1 from home-assistant/dev
carstenschroeder Dec 30, 2018
eb4ff17
Merge pull request #2 from home-assistant/dev
carstenschroeder Jan 12, 2019
c423d3f
Merge pull request #4 from home-assistant/dev
carstenschroeder Feb 2, 2019
b572f3a
Merge pull request #10 from home-assistant/dev
carstenschroeder Feb 10, 2019
b75ee44
Merge pull request #15 from home-assistant/dev
carstenschroeder Feb 19, 2019
70d18d3
Push to pyads 3.0.7
carstenschroeder Feb 19, 2019
1018ba7
Correct too long line
carstenschroeder Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions homeassistant/components/ads/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
EVENT_HOMEASSISTANT_STOP
import homeassistant.helpers.config_validation as cv

REQUIREMENTS = ['pyads==2.2.6']
REQUIREMENTS = ['pyads==3.0.7']

_LOGGER = logging.getLogger(__name__)

Expand Down Expand Up @@ -73,9 +73,10 @@ def setup(hass, config):

try:
ads = AdsHub(client)
except pyads.pyads.ADSError:
except pyads.ADSError:
_LOGGER.error(
"Could not connect to ADS host (netid=%s, port=%s)", net_id, port)
"Could not connect to ADS host (netid=%s, ip=%s, port=%s)",
net_id, ip_address, port)
return False

hass.data[DATA_ADS] = ads
Expand Down Expand Up @@ -168,7 +169,7 @@ def add_device_notification(self, name, plc_datatype, callback):
self._notification_items[hnotify] = NotificationItem(
hnotify, huser, name, plc_datatype, callback)

def _device_notification_callback(self, addr, notification, huser):
def _device_notification_callback(self, notification, name):
"""Handle device notifications."""
contents = notification.contents

Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ pyW800rf32==0.1
# py_noaa==0.3.0

# homeassistant.components.ads
pyads==2.2.6
pyads==3.0.7

# homeassistant.components.sensor.aftership
pyaftership==0.1.2
Expand Down