Skip to content

Fix Homematic IP Cloud configuration #21202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Feb 19, 2019
Merged

Fix Homematic IP Cloud configuration #21202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions homeassistant/components/homematicip_cloud/hap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ async def async_checkbutton(self):
from homematicip.base.base_connection import HmipConnectionError

try:
await self.auth.isRequestAcknowledged()
return True
return await self.auth.isRequestAcknowledged()
except HmipConnectionError:
return False

Expand Down
2 changes: 1 addition & 1 deletion tests/components/homematicip_cloud/test_hap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ async def test_auth_auth_check_and_register(hass):
hap = hmipc.HomematicipAuth(hass, config)
hap.auth = Mock()
with patch.object(hap.auth, 'isRequestAcknowledged',
return_value=mock_coro()), \
return_value=mock_coro(True)), \
patch.object(hap.auth, 'requestAuthToken',
return_value=mock_coro('ABC')), \
patch.object(hap.auth, 'confirmAuthToken',
Expand Down