Skip to content

Add support for DHT and DS18B20 sensors via Konnected firmware#21189

Merged
MartinHjelmare merged 12 commits into
home-assistant:devfrom
konnected-io:konnected
Mar 4, 2019
Merged

Add support for DHT and DS18B20 sensors via Konnected firmware#21189
MartinHjelmare merged 12 commits into
home-assistant:devfrom
konnected-io:konnected

Conversation

@heythisisnate
Copy link
Copy Markdown
Contributor

@heythisisnate heythisisnate commented Feb 18, 2019

Description:

Adds support for digital sensors attached to a Konnected device. Currently the Konnected firmware supports DHT and DS18B20 sensors.

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8626

Example entry for configuration.yaml (if applicable):

konnected:
  access_token: CHANGEME
  devices:
    - id: dc4f223b1525
      sensors:
        - name: Outside
          type: dht
          pin: 6
        - name: Probe
          type: ds18b20
          pin: 7

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Comment thread homeassistant/components/konnected/sensor.py
Comment thread homeassistant/components/konnected/__init__.py Outdated
Comment thread homeassistant/components/konnected/__init__.py Outdated
Comment thread homeassistant/components/konnected/__init__.py Outdated
Comment thread homeassistant/components/konnected/sensor.py Outdated
Comment thread homeassistant/components/konnected/sensor.py Outdated
Comment thread homeassistant/components/konnected/sensor.py Outdated
Comment thread homeassistant/components/konnected/sensor.py Outdated
@heythisisnate
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare @pvizeli thank you for the great feedback. I learned a lot here. I've made the updates requested and it's a lot cleaner now. Would you mind taking another look?

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Comment thread homeassistant/components/konnected/__init__.py Outdated
Comment thread homeassistant/components/konnected/__init__.py Outdated
Comment thread homeassistant/components/konnected/__init__.py Outdated
Comment thread homeassistant/components/konnected/__init__.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@heythisisnate
Copy link
Copy Markdown
Contributor Author

could anyone help out with a merge?

@MartinHjelmare MartinHjelmare merged commit f62eb22 into home-assistant:dev Mar 4, 2019
@ghost ghost removed the in progress label Mar 4, 2019
@balloob balloob mentioned this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants