Add support for DHT and DS18B20 sensors via Konnected firmware#21189
Merged
Conversation
Merged
2 tasks
pvizeli
reviewed
Feb 20, 2019
MartinHjelmare
requested changes
Feb 22, 2019
Contributor
Author
|
@MartinHjelmare @pvizeli thank you for the great feedback. I learned a lot here. I've made the updates requested and it's a lot cleaner now. Would you mind taking another look? |
Member
|
Can be merged when build passes. |
Contributor
Author
|
could anyone help out with a merge? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for digital sensors attached to a Konnected device. Currently the Konnected firmware supports DHT and DS18B20 sensors.
Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8626
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.