Split out iperf3 into a component with a sensor platform#21138
Merged
andrewsayre merged 7 commits intoFeb 23, 2019
Conversation
houndci-bot
reviewed
Feb 18, 2019
houndci-bot
reviewed
Feb 18, 2019
MartinHjelmare
approved these changes
Feb 19, 2019
Member
|
Can be merged when build passes. |
2 tasks
Merged
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Per home-assistant/architecture#131, sensor platforms should not be registering services. iperf3 is one of several that does and this should be cleaned up. This sensor has a service call which is used to manually run a speedtest and then updates the sensor with that information.
I moved all of the setup/service logic to a new iperf3 component and then used that component
inside the sensor platform. All configuration has been moved to the component and the sensor platform is loaded automatically when the component is loaded.
Using a dispatcher signal, the component notifies the platform when it's finished a speedtest so the platform can update it's data.
Same as #20341, #20527 but for iperf3.
Breaking Change: The iperf3 sensor platform has been separated into a component and a sensor to remove the service from the sensor platform. Configuration options have changed, please review the documentation and select the correct options.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8750
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: