Add Environment Canada weather, sensor, and camera platforms#21110
Conversation
|
It looks like you are taking a day+night forecast and chopping out the night time piece except for the low temperature to fit within the current component choices of daily or hourly. I am working on allowing a day+night mode in the front end for my own in-progress platform. I can submit a PR for this piece now if it helps here. See here for what my proposal is Also, as with every other weather platform I've looked at, this one will only show correct values in one unit system, I assume metric. |
|
Yes, I'm only using the high and low temperatures. There is a lot more data available, but I fit it into the existing UI. You're correct that I'm only presenting the data in metric; that's the standard in Canada and is the only way the data is published. |
|
I think at the very least this needs to be an explicit limitation in the documentation if imperial units won't be supported. |
|
I tested it in imperial mode, and it does present the temperatures correctly in ºF. It doesn't look like the weather component supports units or conversions for the other types of data (i.e. wind speed, pressure, and visibility). |
221e967 to
3348c18
Compare
c4fb2af to
7d39ee8
Compare
|
I've had a few users testing things out (see https://community.home-assistant.io/t/reviewers-needed-environment-canada-component-with-weather-sensor-and-camera-radar-platforms/59561), and I decided to merge the weather, sensor, and camera platforms under this PR. Things are running quite smoothly, and I'd like to get this merged in 0.90 if possible. Please let me know if you have any questions or concerns. |
|
I've been testing this platform as a custom component on 0.88 and 0.89 without issues. This platform follows the style of other national weather service platforms. Canadian Home Assistant users will be pleased to see the integration of official weather data. 🇨🇦 Thanks for the hard work @michaeldavie |
|
Great work on this. Been using since your first pull request back last year... I think you should drop the |
|
@balloob, would it be possible to get this merged? It's running stably with quite a few users, and the documentation has been brought up to date. Please let me know if there's anything else I need to do. Thanks in advance for your help. |
…sistant#21110) * Added Environment Canada weather platform * Added Environment Canada weather platform * Migrate to new folder structure * Migrate to new folder structure * Fix updates * Fix updates again * Bump env_canada to 0.0.4 * Bump env_canada to 0.0.4 * Bump env_canada to 0.0.4 in requirements_all.txt * Change daily forecast timestamp and high/low test * Change daily forecast timestamp and high/low test * Bump env_canada to 0.0.5 * Break alerts into multiple sensors, bump env_canada to 0.0.6 * Bump env_canada to 0.0.7 * Remove blank line * Remove 'ec' sensor prefix, bump env_canada to 0.0.8 * Corrections * Change to manifests.json * Add docstring to __init.py__ * Update CODEOWNERS * pylint correction * pylint correction * Add alert details, bump env_canada to 0.0.9 * Update requirements_all.txt * Update .coveragerc * Bump env_canada to 0.0.10 * Update requirements_all.txt
Description: Add platforms for Environment Canada weather data to the weather, sensor, and camera components.
**Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8604
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: