SmartThings Component Enhancements/Fixes#21085
Merged
MartinHjelmare merged 4 commits intoFeb 15, 2019
Merged
Conversation
Member
Author
|
Uhg! There's a bug! Apparently I can't get to this until this evening, so anyone is welcome to fix. |
Member
|
I'm not sure about this. @balloob? |
Member
Author
|
Yeah and I added the placeholder after testing it, so shame on me for not retesting!! |
This was referenced Feb 15, 2019
balloob
pushed a commit
that referenced
this pull request
Feb 18, 2019
* Improve component setup error logging/notification * Prevent capabilities from being represented my multiple platforms * Improved logging of received updates * Updates based on review feedback
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Improves the SmartThings Component:
Prior to this change, Thermostats would show up as both the climate platform and 3-4 sensors -- but the sensors represent attributes already covered by the climate platform.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.If the code does not interact with devices: