Skip to content

SmartThings Component Enhancements/Fixes#21085

Merged
MartinHjelmare merged 4 commits into
home-assistant:devfrom
andrewsayre:smartthings-enhancements
Feb 15, 2019
Merged

SmartThings Component Enhancements/Fixes#21085
MartinHjelmare merged 4 commits into
home-assistant:devfrom
andrewsayre:smartthings-enhancements

Conversation

@andrewsayre
Copy link
Copy Markdown
Member

Description:

Improves the SmartThings Component:

  • Displays specific error message to user when SmartThings cannot validate the webhook during setup (vs. generic error today)
  • Improves logging of errors received from the SmartThings API during component setup
  • Improves logging of push updates received
  • Fix so capabilities are not represented by more than one platform that covers the same data attribute.
    Prior to this change, Thermostats would show up as both the climate platform and 3-4 sensors -- but the sensors represent attributes already covered by the climate platform.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/smartthings/__init__.py
Comment thread homeassistant/components/smartthings/config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 93f84a5 into home-assistant:dev Feb 15, 2019
@ghost ghost removed the in progress label Feb 15, 2019
@andrewsayre
Copy link
Copy Markdown
Member Author

Uhg! There's a bug! Apparently description_placeholders doesn't also populate error messages with a place holder. I don't see any error_placeholders implementation -- is this not supported? I'll need to remove the link from the new error message.

I can't get to this until this evening, so anyone is welcome to fix.

@MartinHjelmare
Copy link
Copy Markdown
Member

I'm not sure about this. @balloob?

@andrewsayre
Copy link
Copy Markdown
Member Author

Yeah and I added the placeholder after testing it, so shame on me for not retesting!!

@andrewsayre andrewsayre deleted the smartthings-enhancements branch February 15, 2019 23:18
@andrewsayre andrewsayre added this to the 0.88.0 milestone Feb 17, 2019
balloob pushed a commit that referenced this pull request Feb 18, 2019
* Improve component setup error logging/notification

* Prevent capabilities from being represented my multiple platforms

* Improved logging of received updates

* Updates based on review feedback
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants