Skip to content

Point alarm control#20972

Merged
MartinHjelmare merged 7 commits into
home-assistant:devfrom
fredrike:point-alarm_control
Feb 15, 2019
Merged

Point alarm control#20972
MartinHjelmare merged 7 commits into
home-assistant:devfrom
fredrike:point-alarm_control

Conversation

@fredrike
Copy link
Copy Markdown
Contributor

@fredrike fredrike commented Feb 11, 2019

Description:

Adds support for toggling the alarm part of the Minut Point.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8477

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Wip:

  • Community tests.
  • Version bump github.com/fredrike/pypoint.
  • (Supported features of alarm_control_panel), apparently doesn't the alarm_control_panel implement supported features like the climate platform does.

@fredrike fredrike changed the title wip: Point alarm control Point alarm control Feb 14, 2019
@fredrike fredrike force-pushed the point-alarm_control branch from 1cd0bb8 to 589a173 Compare February 14, 2019 08:23
Comment thread homeassistant/components/point/alarm_control_panel.py Outdated
Comment thread homeassistant/components/point/alarm_control_panel.py Outdated
Comment thread homeassistant/components/point/alarm_control_panel.py Outdated
Comment thread homeassistant/components/point/alarm_control_panel.py Outdated
Comment thread homeassistant/components/point/alarm_control_panel.py
@MartinHjelmare MartinHjelmare merged commit f3786e2 into home-assistant:dev Feb 15, 2019
@ghost ghost removed the in progress label Feb 15, 2019
@fredrike
Copy link
Copy Markdown
Contributor Author

Will this reach 0.88?

@MartinHjelmare
Copy link
Copy Markdown
Member

No, 0.89.

@fredrike fredrike deleted the point-alarm_control branch March 4, 2019 06:54
@balloob balloob mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants