Skip to content

Fix STATE_UNLOCKED for verisure #20858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvizeli merged 1 commit into from
Feb 8, 2019
+1 −1
Merged

Fix STATE_UNLOCKED for verisure #20858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/verisure/lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def update(self):
"$.doorLockStatusList[?(@.deviceLabel=='%s')].lockedState",
self._device_label)
if status == 'UNLOCKED':
self._state = None
self._state = STATE_UNLOCKED
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Feb 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should instead remove the state property in the verisure lock entity class, and implement is_locked. Lock platforms should not overwrite the state property.

elif status == 'LOCKED':
self._state = STATE_LOCKED
elif status != 'PENDING':
Expand Down