Skip to content

Fix bug with monitored_conditions in Ambient PWS#20837

Merged
fabaff merged 4 commits into
home-assistant:devfrom
bachya:monitored_conditions
Feb 11, 2019
Merged

Fix bug with monitored_conditions in Ambient PWS#20837
fabaff merged 4 commits into
home-assistant:devfrom
bachya:monitored_conditions

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Feb 7, 2019

Description:

A bug existed in the Ambient PWS component where monitored_conditions would be stored in the config entry. Those values would then be used on every load, regardless of any value changes in configuration.yaml. This PR fixes that.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

ambient_station:
  api_key: !secret ambient_pws_api_key
  app_key: !secret ambient_pws_app_key

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@bachya bachya force-pushed the monitored_conditions branch from 2e31f68 to 33dddf8 Compare February 8, 2019 04:42
@bachya bachya changed the title WIP: Fix bug with monitored_conditions in Ambient PWS Fix bug with monitored_conditions in Ambient PWS Feb 8, 2019
@fabaff fabaff merged commit b5b03f5 into home-assistant:dev Feb 11, 2019
@ghost ghost removed the in progress label Feb 11, 2019
@bachya bachya deleted the monitored_conditions branch February 12, 2019 23:48
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants