Skip to content

Add additional devices and features to Homematic IP#20747

Merged
MartinHjelmare merged 11 commits into
home-assistant:devfrom
SukramJ:dev
Feb 8, 2019
Merged

Add additional devices and features to Homematic IP#20747
MartinHjelmare merged 11 commits into
home-assistant:devfrom
SukramJ:dev

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Feb 4, 2019

Description:

  • updated depency for homematicip to 0.10.5 (required for HmIP-SLO)
  • Added support for HmIP-SLO Lightsensor
  • Added power measure for HmIP-BSM, HmIP-FSM, HmIP-PSM

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@SukramJ SukramJ requested a review from a team as a code owner February 4, 2019 19:19
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @SukramJ,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@worm-ee
Copy link
Copy Markdown
Contributor

worm-ee commented Feb 4, 2019

Hi, I just wanted to update to 0.10.5 when I stumbled across your PR. Thanks for adding those devices!

Ciao Mattias

@pvizeli pvizeli removed the request for review from a team February 5, 2019 10:18
Comment thread homeassistant/const.py Outdated
@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Feb 5, 2019

@mxworm : Can you have a look at the code?

@fabaff fabaff changed the title Homematic IP: add additional devices and features Add additional devices and features to Homematic IP Feb 5, 2019
@worm-ee
Copy link
Copy Markdown
Contributor

worm-ee commented Feb 6, 2019

Hi, I'm fine with the code, can be merged.

Thanks

Comment thread homeassistant/components/homematicip_cloud/sensor.py Outdated
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Feb 7, 2019

Please fix the lint, after that we can merge it

@MartinHjelmare
Copy link
Copy Markdown
Member

@pvizeli are there any lint issues left?

@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Feb 8, 2019

@pvizeli , @MartinHjelmare
Is there any thing i can do? I think there is no lint left.

@MartinHjelmare
Copy link
Copy Markdown
Member

Should be fine.

@MartinHjelmare MartinHjelmare merged commit ca0e5a7 into home-assistant:dev Feb 8, 2019
@ghost ghost removed the in progress label Feb 8, 2019
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants