Fix the line reference in config error message#20743
Merged
balloob merged 4 commits intohome-assistant:devfrom Feb 4, 2019
Merged
Fix the line reference in config error message#20743balloob merged 4 commits intohome-assistant:devfrom
balloob merged 4 commits intohome-assistant:devfrom
Conversation
ghost
assigned
balloob
reviewed
Feb 4, 2019
Member
|
Tagging for 87 because better errors are better 👍 |
balloob
approved these changes
Feb 4, 2019
balloob
pushed a commit
that referenced
this pull request
Feb 5, 2019
* Fix the line reference in config error message * Fix platform config validation * Fix test * Handle error in error handling routine
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The platform configuration will go through double validation, first on component level then platform level.
The error handling in the latter validation was passing the result of first validation which already lost meta information about the configuration file and line number.
Related issue (if applicable): fixes #20738
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass